gtk: fix context menu computed location #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…viour at edges and closeness to cursor
…ove behaviour at edges and closeness to cursor" This reverts commit bf5351e.
|
Open to merge if tests pass EDIT: Nevermind, that's caused by #5644. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tab bar is displayed, the context menu opened with right click is offset from the cursor.
This was due to using the incorrect coordinate space for describing where to draw the context menu.
gtk_popover_set_pointing_to uses the coordinate space of the popover's parent, however we used the active window's coordinate space which was noticeably different when the tab bar is visible.
Before:
After: